Austenem/CAT-872 improve redirect toast #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-conroy
reviewed
Oct 4, 2024
john-conroy
reviewed
Oct 7, 2024
john-conroy
reviewed
Oct 7, 2024
Comment on lines
13
to
14
| redirectedFromId?: string; | ||
| redirectedFromPipeline?: string; |
There was a problem hiding this comment.
The .get without a second argument will resolve to None if the key isn't present and will then be null once converted to json. The types here should be ?: string | null.
There was a problem hiding this comment.
Got it - is this preferable to providing a false second value to .get?
john-conroy
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Unified View redirect toast to be more informative with the processing type and HuBMAP ID of the redirected dataset.
Design Documentation/Original Tickets
CAT-872 Jira ticket
Testing
Manually checked toast for several raw and processed datasets.
Screenshots/Video
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.