-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Austenem/CAT-872 improve redirect toast #3556
Conversation
redirectedFromId?: string; | ||
redirectedFromPipeline?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .get
without a second argument will resolve to None
if the key isn't present and will then be null
once converted to json. The types here should be ?: string | null
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it - is this preferable to providing a false second value to .get
?
Summary
Update Unified View redirect toast to be more informative with the processing type and HuBMAP ID of the redirected dataset.
Design Documentation/Original Tickets
CAT-872 Jira ticket
Testing
Manually checked toast for several raw and processed datasets.
Screenshots/Video
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.